impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4033: Improvements of partition DDL.
Date Fri, 16 Dec 2016 21:33:23 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4033: Improvements of partition DDL.
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5535/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-4033: Improvements of partition DDL.
This description could be more precise. What improvements?


Line 9: This commit makes ADD PARTITION op treat string partition-key values as case
long line


PS1, Line 9: op
"operations"


PS1, Line 10: in consistency
"consistent"


http://gerrit.cloudera.org:8080/#/c/5535/1/fe/src/main/java/org/apache/impala/analysis/PartitionSpec.java
File fe/src/main/java/org/apache/impala/analysis/PartitionSpec.java:

Line 85:       if (!keyNames.add(pk.getColName())) {
The changes in this file look like they is about the partition column name, not the value.
Can you explain to me why they are needed, and if they need additional tests?


-- 
To view, visit http://gerrit.cloudera.org:8080/5535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbe67d99df8a50a16a18456fde85d03d622c7a1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Amos Bird <amosbird@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message