impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API
Date Thu, 15 Dec 2016 23:00:48 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5526/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java
File fe/src/main/java/org/apache/impala/service/JniFrontend.java:

PS1, Line 727: 
Quick search says this is obsolete too. https://issues.apache.org/jira/browse/HDFS-10868 .The
patch for HDFS-8895 [1] seems to have removed this.  Should we even rely on this check? Doesn't
the compilation with hadoop-next point this?

[1] https://issues.apache.org/jira/secure/attachment/12750398/HDFS-8895.001.patch


-- 
To view, visit http://gerrit.cloudera.org:8080/5526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12337a9f5b7d910282aaf7d8508a4176cf89cbc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message