impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4647: fix full data load with ninja
Date Thu, 15 Dec 2016 21:28:17 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4647: fix full data load with ninja
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5476/2/buildall.sh
File buildall.sh:

Line 62: export MAKE_CMD=make
> Then shouldn't this be re-exported after the -ninja flag is processed?
export promotes a variable to be an environment variable - it stays exported when it's reassigned
below.


-- 
To view, visit http://gerrit.cloudera.org:8080/5476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba00d0ffbb6a93f26f4e2d1d311167d5e4dfa99f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message