impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.
Date Thu, 15 Dec 2016 21:20:54 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

Patch Set 1:

Sorry for the confusion. As a general rule we do one commit per JIRA, in particular, for bug
fixes. That makes it easier to manage backports/patches, and also easier for users to see
which changes were fixed by which JIRA. It does sometimes add overhead to the developer, but
it saves many more people a lot of time, so we see it as a net win for the project.

Like you've seen, there are some exceptions:
Sometimes we group JIRAs into a single commit if one change (fix) addresses multiple issues
(symptoms) that were reported separately. Other times we may group sub-tasks of a larger feature
that have separate JIRAs into one commit.

How to proceed:
I suggest abandoning this code review and sending out two new separate code reviews.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4e46ec0a63b46e485141290268d019c3dd15c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Amos Bird <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Amos Bird <>
Gerrit-HasComments: No

View raw message