impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make
Date Thu, 15 Dec 2016 17:45:54 GMT
Hello Jim Apple, Sailesh Mukil,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5480

to look at the new patch set (#3).

Change subject: IMPALA-4649: add a mechanism to pass flags into make
......................................................................

IMPALA-4649: add a mechanism to pass flags into make

Testing:
Tested that buildall.sh works as expected. Built locally with
IMPALA_MAKE_FLAGS unset to confirm I didn't break anything.

Built locally with
IMPALA_MAKE_FLAGS=--load-average=$IMPALA_BUILD_THREADS and looked
at "ps auxf" output to confirm it's passed through.

Change-Id: I17b13cbaf395f962762d5cff3d650ffb077934a4
---
M bin/impala-config.sh
M bin/make_impala.sh
M testdata/bin/copy-udfs-udas.sh
3 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/5480/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17b13cbaf395f962762d5cff3d650ffb077934a4
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message