impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML
Date Thu, 15 Dec 2016 16:36:10 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4355: random query generator: modify statement execution flow to support
DML
......................................................................


Patch Set 4:

(1 comment)

I made some adjustments to the discrepancy searcher after doing more testing. I changed table/view
cleanup to the main thread so cleanup would work even if we had to time out a connection,
and I added some reporting.

http://gerrit.cloudera.org:8080/#/c/5387/1/tests/comparison/query.py
File tests/comparison/query.py:

Line 111:   from_clause are required for a valid query.
> It's fine to leave it like this. The AbstractStatement has this set to None
I realized the better way to do this is to use a property that checks if the attribute is
being accessed. If the attribute is None, then raise an exception. That way callers don't
have to remember to do it themselves. This is done in patch set 4.


-- 
To view, visit http://gerrit.cloudera.org:8080/5387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c63a2223185d0e056cc5713796772e5d1b8414
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message