impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates
Date Thu, 15 Dec 2016 00:22:31 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5505/1/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:

PS1, Line 384: prediates
Typo: predicates


http://gerrit.cloudera.org:8080/#/c/5505/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
File testdata/workloads/functional-planner/queries/PlannerTest/kudu.test:

PS1, Line 319: select id from functional_kudu.alltypestiny where id in (1, null);
Is it necessary to add additional tests for other types? (string, bool, etc.)


-- 
To view, visit http://gerrit.cloudera.org:8080/5505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2c10a326373ad80aef51a85cec64071daefa7b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message