impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.
Date Wed, 14 Dec 2016 21:24:05 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5446/3/tests/conftest.py
File tests/conftest.py:

Line 480:   Validate that pytest command line options makes sense.
> typo: make sense
Done


Line 483:     if "localhost" in pytest.config.option.impalad:
> Any address starting with 127.x.x.x is the local machine I think.
Done


Line 483:     if "localhost" in pytest.config.option.impalad:
> or "127.0.0.1" ?
Done


http://gerrit.cloudera.org:8080/#/c/5446/3/tests/metadata/test_compute_stats.py
File tests/metadata/test_compute_stats.py:

Line 135:                      reason=("Because of the way we pre-split the data, setting
up HBase "
> add JIRA to the reason, so we can easily fix all the places later if needed
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message