impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Clarify synchronization policy for 'done ' in KuduScanNode
Date Wed, 14 Dec 2016 18:02:25 GMT
Lars Volker has posted comments on this change.

Change subject: Clarify synchronization policy for 'done_' in KuduScanNode
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5494/1//COMMIT_MSG
Commit Message:

Line 7: Clarify synchronization policy for 'done_' in KuduScanNode
Is there a Jira?


PS1, Line 9: calrify
typo


http://gerrit.cloudera.org:8080/#/c/5494/1/be/src/exec/kudu-scan-node.h
File be/src/exec/kudu-scan-node.h:

Line 99:   /// contention.
Does it make sense to add small comments at the particular places, explaining why it is not
necessary to protect the reads?


-- 
To view, visit http://gerrit.cloudera.org:8080/5494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72c5f1fecf4bcf737d71a1fa13e59361604485f0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message