impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()
Date Wed, 14 Dec 2016 00:40:35 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit()
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5493/2/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 105:     RETURN_IF_CANCELLED(state_);
Does this do anything?

Other scanners do:

RETURN_IF_ERROR(state_->GetQueryStatus());

Looks like we also do that in

DecodeRowsIntoRowBatch()

Any idea why these checks were not sufficient to stop the thread from continuing to execute?


http://gerrit.cloudera.org:8080/#/c/5493/2/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

Line 627:       v.wait_for_metric("impala-server.num-fragments-in-flight", 0, timeout=30)
How sure are you this won't be flaky? Time seems tight to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/5493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaddd51111a1b2647995d68e6d37d0500b3a322de
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message