impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool
Date Mon, 12 Dec 2016 18:24:46 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5453/1/be/src/util/parquet-reader.cc
File be/src/util/parquet-reader.cc:

Line 255:   vector<int> column_rows;
A little confusing, maybe 'column_num_rows'?


Line 299:       assert(column_rows[0] == column_rows[c]);
Add a comment, eg. "Check that all cols have the same number of rows"


-- 
To view, visit http://gerrit.cloudera.org:8080/5453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I281a784a0aa2df4ed1852dfb864587a0c1aa4d9a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message