impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4639: Add pytest option and skip markers for tests that only run locally.
Date Sat, 10 Dec 2016 05:26:29 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4639: Add pytest option and skip markers for tests that only run locally.

Patch Set 2:


Is the motivation of this change to get Jenkins jobs run against a remote cluster green? Please
briefly summarize the motivation of this change.
File tests/common/

Line 122:   mini_cluster_only = pytest.mark.skipif(pytest.config.option.testing_remote_cluster,
Why skip and not xfail? With xfail we have the option of still running the tests, e.g., to
detect crashes.
File tests/

Line 108:   parser.addoption("--testing_remote_cluster", action="store_true", default=False,
I'm ok with adding this flag, but I think we should enforce its semantics. Currently, we can
set this flag regardless of whether we are testing on a remote cluster or not which seems
potentially error-prone.

Line 109:                    help="Indicates that tests are being run against a remote cluster.")
Mention what effect this flag has. It will cause tests to be skipped.
File tests/query_test/

Line 95:   @SkipIfRemoteTesting.mini_cluster_only
Does or succeed on a remote cluster? I'm
surprised that only this test would be skipped of loading tpch_nested is not working.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message