impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add pytest option and skip markers for tests that only run locally.
Date Fri, 09 Dec 2016 23:21:12 GMT
Lars Volker has posted comments on this change.

Change subject: Add pytest option and skip markers for tests that only run locally.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5446/1/tests/common/skip.py
File tests/common/skip.py:

PS1, Line 123: --skip_local_only_tests
Could this ever be re-used by some other dev without that command line option being present?
Then the error might be misleading.


PS1, Line 124: hbase_split
Is this used anywhere?


PS1, Line 125: HBase is not split on remote cluster the same as on the local cluster.
This doesn't tell me much, probably because I don't know how splitting works local and/or
remote. Maybe you can rephrase to explain what exactly is different.


http://gerrit.cloudera.org:8080/#/c/5446/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:

PS1, Line 95: @SkipIfRemoteTesting.local_cluster_only
>From just looking at this it is not clear to me whether this is skipped or only runs locally
/ remotely.


-- 
To view, visit http://gerrit.cloudera.org:8080/5446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message