impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test
Date Fri, 09 Dec 2016 18:25:14 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4467: Add support for DML statements in stress test
......................................................................


Patch Set 3: Code-Review+1

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5093/2/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

PS2, Line 1417: 
> For performance, it's faster to check if an element exists in a set than a 
Done


PS2, Line 1464:       insert_query.modifies_table = False
> Not sure, is it always going to be the case that a column is updatable if a
It's possible updatale_column_names is a bad name. In any case, it currently returns all the
columns that are not primary keys, very similar to your expression above.


PS2, Line 1466:       insert_query.name = "insert_{0}".format(table.name)
              :       insert_query.db_name = cursor.db_name
              :       insert_query.sql = (
> Done
That makes a notable difference. Thanks.


http://gerrit.cloudera.org:8080/#/c/5093/3/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

PS3, Line 1461: this will still be still
Some extra words here.


PS3, Line 1657: quereis
spelling: queries


-- 
To view, visit http://gerrit.cloudera.org:8080/5093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2aafdc6851cc0e1677a3c668d3350e47c4bfe40
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message