impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test
Date Fri, 09 Dec 2016 18:25:14 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4467: Add support for DML statements in stress test

Patch Set 3: Code-Review+1

File tests/stress/

PS2, Line 1417: 
> For performance, it's faster to check if an element exists in a set than a 

PS2, Line 1464:       insert_query.modifies_table = False
> Not sure, is it always going to be the case that a column is updatable if a
It's possible updatale_column_names is a bad name. In any case, it currently returns all the
columns that are not primary keys, very similar to your expression above.

PS2, Line 1466: = "insert_{0}".format(
              :       insert_query.db_name = cursor.db_name
              :       insert_query.sql = (
> Done
That makes a notable difference. Thanks.
File tests/stress/

PS3, Line 1461: this will still be still
Some extra words here.

PS3, Line 1657: quereis
spelling: queries

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2aafdc6851cc0e1677a3c668d3350e47c4bfe40
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: Yes

View raw message