impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions
Date Fri, 09 Dec 2016 06:19:21 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4631: don't use floating point operations for time unit conversions
......................................................................


Patch Set 4:

> Change looks good.
 > 
 > There seems to be something similar in walltime.cc too so would be
 > nice to clean them up too:
 > 
 > https://github.com/apache/incubator-impala/blob/master/be/src/gutil/walltime.cc#L173
 > 

This was dead code, so I removed it instead. It appears to have been added by Impala but not
used (as opposed to coming from gperfutil).

 > And something similar in util/os-util.cc

I think we actually want to keep that one as floating point because the TICKS_PER_SEC may
not divide into 1 billion evenly, so we'd lose precision in that case.

-- 
To view, visit http://gerrit.cloudera.org:8080/5434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7237f579b201f5bd3930f66e9c2c8d700c37ffeb
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message