impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs
Date Fri, 09 Dec 2016 01:33:09 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
......................................................................


IMPALA-4608: Fix fragment completion times for INSERTs

Fix a bug where completion times weren't computed if the query was an
INSERT, because the code presumed that instance 0 was always the
coordinator fragment and skipped completion time computation.

It may be that the special-casing can be removed entirely, but needs
further investigation to make sure that wouldn't trigger any div-by-0 bugs.

Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893
Reviewed-on: http://gerrit.cloudera.org:8080/5418
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/coordinator.cc
1 file changed, 6 insertions(+), 9 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Henry Robinson: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message