impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML
Date Thu, 08 Dec 2016 21:34:33 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4355: random query generator: modify statement execution flow to support
DML
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5387/1/tests/comparison/statement_generator.py
File tests/comparison/statement_generator.py:

PS1, Line 37: self.query_generator = QueryGenerator(profile)
> Why composition VS. inheritance?
Oops, that line probably shouldn't be there, but I'll answer the question since it's fair
to ask.

Composition seemed natural for what some DML statements are anyway: an INSERT or UPSERT statement
might have-a SELECT query, or it might not. In that sense, the INSERT or UPSERT requests from
QueryGenerator() a SELECT, so whatever is generating the INSERT/UPSERT is an external user
of the QueryGenerator API. This also mimics our query model:

https://github.com/apache/incubator-impala/blob/master/tests/comparison/query.py#L726


-- 
To view, visit http://gerrit.cloudera.org:8080/5387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c63a2223185d0e056cc5713796772e5d1b8414
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message