impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs
Date Thu, 08 Dec 2016 21:32:33 GMT
Hello Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5418

to look at the new patch set (#3).

Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
......................................................................

IMPALA-4608: Fix fragment completion times for INSERTs

Fix a bug where completion times weren't computed if the query was an
INSERT, because the code presumed that instance 0 was always the
coordinator fragment and skipped completion time computation.

It may be that the special-casing can be removed entirely, but needs
further investigation to make sure that wouldn't trigger any div-by-0 bugs.

Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893
---
M be/src/runtime/coordinator.cc
1 file changed, 6 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/5418/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>

Mime
View raw message