impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests
Date Thu, 08 Dec 2016 20:24:57 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-2605: Omit the sort and mini stress tests
......................................................................


Patch Set 2:

> One option we should consider is replacing this test with a small
 > run of our "regular" stress test run. That way we don't lose
 > coverage and arguably our regular stress runs are better.

Do you mean tests/stress/concurrent_select? Which queries do you think would be of interest?
I ask because the comment seems to indicate it is parameterized, with queries that must be
passed in by the user.

This is a substantial script (1500 lines) and it seems to be designed to be "a slow process",
so tuning it to the needs of pre-merge testing may be lower impact per hour spent than some
of my other Impala projects, especially given the risk that it turns out to not be possible
to fit it into our current e2e tests framework.

-- 
To view, visit http://gerrit.cloudera.org:8080/5401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd30abf8215415e0f2830b725e43b005daa2bb2d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message