impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs
Date Thu, 08 Dec 2016 20:04:48 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5418/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 1673:       if (executor_ == nullptr || state->fragment_idx() != 0) {
can you leave a comment explaining what the special case is (i.e. skipped for the coordinator
fragment).


-- 
To view, visit http://gerrit.cloudera.org:8080/5418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce56f70d30c9e398b14b32520c815d87f81f893
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message