impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline
Date Thu, 08 Dec 2016 17:37:58 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4588: Enable starting the minicluster when offline
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5412/1/testdata/cluster/admin
File testdata/cluster/admin:

Line 302:            && ping -c 1 -w 5 pool.ntp.org >/dev/null 2>/dev/null \
Can we add a log message here if the ping fails so that there's a breadcrumb to follow if
a new developer's Kudu fails to start.


-- 
To view, visit http://gerrit.cloudera.org:8080/5412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb5babebb0ca6d2553be1b001e20e2270e052b6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message