impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3788: Fix Kudu ReadMode flag checking
Date Thu, 08 Dec 2016 03:53:52 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3788: Fix Kudu ReadMode flag checking
......................................................................


IMPALA-3788: Fix Kudu ReadMode flag checking

Commit 0d4bdc1 to add flag --kudu_read_mode wasn't checking
the value properly; so the behavior was reversed. This
became apparent immediately in stress testing, though there
isn't a good way to validate this in EE or unit tests. I
added some logging which I used to verify the correct
behavior manually in the minicluster.

Change-Id: I843842560844732505af53ea360a3a9ccbab04a9
Reviewed-on: http://gerrit.cloudera.org:8080/5402
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/kudu-scanner.cc
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Matthew Jacobs: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I843842560844732505af53ea360a3a9ccbab04a9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message