impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4539: fix bug when scratch batch references I/O buffers
Date Thu, 08 Dec 2016 00:31:43 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4539: fix bug when scratch batch references I/O buffers
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5406/2/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 243:     // The scratch batch may still contain rows, (or tuple ptrs if the legacy joins
or
... may still contain tuple data, (or ...


Line 245:     // cancelled at the wrong point.
remove "at the wrong point"


Line 600:   if (scratch_batch_->AtEnd()
Seems simpler to do this in TransferScratchTuples() when scratch_batch_->AtEnd(). That's
where we transfer the other resources to the dst batch.


-- 
To view, visit http://gerrit.cloudera.org:8080/5406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic27e7251e0f633cb694b506f6eb62beed6e66ad9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-HasComments: Yes

Mime
View raw message