impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
Date Thu, 08 Dec 2016 00:24:26 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
......................................................................


Patch Set 5:

(3 comments)

Thanks for the review. Please see PS6.

http://gerrit.cloudera.org:8080/#/c/5390/5/fe/src/main/java/org/apache/impala/analysis/ShowPartitionsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ShowPartitionsStmt.java:

Line 30: public class ShowPartitionsStmt extends ShowStatsStmt {
> What's the benefit of subclassing ShowStatStmt? Why not just merge the code
The idea was to keep this change as small as possible. I removed this file now and unified
the behavior in ShowStatStmt, which does look better.


http://gerrit.cloudera.org:8080/#/c/5390/5/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:

Line 422:     String header = "RANGE (" + Joiner.on(',').join(getRangeDistributionColNames())
+ ")";
> nit: blank lines seem superfluous from here onward
Done


http://gerrit.cloudera.org:8080/#/c/5390/5/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

Line 117:     name = unique_database + "." + self.random_table_name()
> why random table name? unique_database already takes care of that
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5b2fdd02938a42fa59ec98884e4ac915dd1f65
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburkert@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message