impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4586: don't constant fold in backend
Date Wed, 07 Dec 2016 21:50:02 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4586: don't constant fold in backend

Patch Set 7: Code-Review+1


Looks okay to me. Alex can give the +2 when he finishes his review.
Commit Message:

PS6, Line 26: In a future change we should remove the IsConstant()
            : analysis logic from the backend entirely and pass the information from
            : the frontend.
> That also depends on fixing IsConstant()/isConstant() so that we can always
Yes, agree (and I think we should do that eventually -- IsConstant() should mean what it says.
Probably UDFs should have a way to annotate their constness and use that so that non-deterministic
UDFs return false for isConstant).
Commit Message:

Line 31: of IsLiteral().
how about filing a JIRA to do this, and then reference that JIRA at the IsLiteral() check
as a TODO?
File be/src/exprs/expr.h:

PS7, Line 168:  must match
but it doesn't match today, right? do we have a JIRA for that, which we could reference here
to clarify that point?
File be/src/exprs/

PS7, Line 220:  
maybe add the clarification: (yet IsConstant() returns true for)

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c76e3c8a8d92749256c312080ecd7aac5d99ce7
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message