impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4586: don't constant fold in backend
Date Wed, 07 Dec 2016 21:50:02 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4586: don't constant fold in backend
......................................................................


Patch Set 7: Code-Review+1

(4 comments)

Looks okay to me. Alex can give the +2 when he finishes his review.

http://gerrit.cloudera.org:8080/#/c/5391/6//COMMIT_MSG
Commit Message:

PS6, Line 26: In a future change we should remove the IsConstant()
            : analysis logic from the backend entirely and pass the information from
            : the frontend.
> That also depends on fixing IsConstant()/isConstant() so that we can always
Yes, agree (and I think we should do that eventually -- IsConstant() should mean what it says.
Probably UDFs should have a way to annotate their constness and use that so that non-deterministic
UDFs return false for isConstant).


http://gerrit.cloudera.org:8080/#/c/5391/7//COMMIT_MSG
Commit Message:

Line 31: of IsLiteral().
how about filing a JIRA to do this, and then reference that JIRA at the IsLiteral() check
as a TODO?


http://gerrit.cloudera.org:8080/#/c/5391/7/be/src/exprs/expr.h
File be/src/exprs/expr.h:

PS7, Line 168:  must match
but it doesn't match today, right? do we have a JIRA for that, which we could reference here
to clarify that point?


http://gerrit.cloudera.org:8080/#/c/5391/7/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

PS7, Line 220:  
maybe add the clarification: (yet IsConstant() returns true for)


-- 
To view, visit http://gerrit.cloudera.org:8080/5391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c76e3c8a8d92749256c312080ecd7aac5d99ce7
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message