impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3788: Fix Kudu ReadMode flag checking
Date Wed, 07 Dec 2016 21:32:26 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3788: Fix Kudu ReadMode flag checking
......................................................................


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > Seems fine. We could avoid compare() though to avoid any confusion
 > about the polarity of the result.

Yeah we should, good call. I had strcmp on my mind from the first review and thus went with
the C++ string compare.

http://gerrit.cloudera.org:8080/#/c/5402/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

PS1, Line 142: compare
> why not just (MORE_READ_AT_SNAPSHOT == FLAGS_kudu_read_mode)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I843842560844732505af53ea360a3a9ccbab04a9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message