impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog
Date Wed, 07 Dec 2016 19:33:46 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5393/1/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

PS1, Line 38: (equivalent to -v)
> Unfortunately vmodule wouldn't help, there are many modules and we can't kn
Re: --vmmodule, i was thinking we'd have a module called 'kudu_client' that translated to
setting the kudu log level. maybe that's also confusing though.

I'm fine with this change if you think it's helpful. You decide. (And okay with the help text
if it's consistent with what we already had).


-- 
To view, visit http://gerrit.cloudera.org:8080/5393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59d431d93c9b4a21111109e59b9894e294d1977a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message