impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files
Date Wed, 07 Dec 2016 19:33:19 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5400/3/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 175:       ADD_COUNTER(scan_node_->runtime_profile(), "NumScannersWithMisalignedRowGroups",
I think the name here is confusing - it seems like its really counting the number of scanners
that don't do any reads, and there could be a scanner with a misaligned group that doesn't
get counted here because it still has some reads.

Maybe call it something like "NumScannersWithNoReads"?


http://gerrit.cloudera.org:8080/#/c/5400/3/be/src/exec/hdfs-scan-node-base.cc
File be/src/exec/hdfs-scan-node-base.cc:

Line 868: void HdfsScanNodeBase::LogPoorlyFormattedParquetFileWarning(const std::string &filename)
{
'string&'


http://gerrit.cloudera.org:8080/#/c/5400/3/be/src/exec/hdfs-scan-node-base.h
File be/src/exec/hdfs-scan-node-base.h:

Line 279:   void LogPoorlyFormattedParquetFileWarning(const std::string &filename);
'string&' instead of '&filename'


-- 
To view, visit http://gerrit.cloudera.org:8080/5400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf48d978383d73efdade733a892e795ebd53c76a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message