impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog
Date Wed, 07 Dec 2016 19:27:54 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5393/1/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

PS1, Line 38: (equivalent to -v)
> i'm not sure what this means given that this is a different option than -v.
Unfortunately vmodule wouldn't help, there are many modules and we can't know them in advance.


This was based on the flag we have in logging-support:

DEFINE_int32(non_impala_java_vlog, 0, "(Advanced) The log level (equivalent to --v) for "
    "non-Impala Java classes (0: INFO, 1 and 2: DEBUG, 3: TRACE)");


And the -v help (from glog itself) says:
    -v (Show all VLOG(m) messages for m <= this. Overridable by --vmodule.)
      type: int32 default: 0


That help is somewhat obscure for end users IMO. If you think this is all too weird I'm OK
with us not doing this, I don't think it's critical. I've had it on in my testing the last
week or so, but I'll try removing it and making sure it's still OK. I think the important
change is about the severity level Thomas posted the patch for.


-- 
To view, visit http://gerrit.cloudera.org:8080/5393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59d431d93c9b4a21111109e59b9894e294d1977a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message