impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4595: Ignore discarded functions after linking
Date Wed, 07 Dec 2016 16:48:19 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4595: Ignore discarded functions after linking
......................................................................


Patch Set 3: Code-Review+1

(7 comments)

http://gerrit.cloudera.org:8080/#/c/5384/3/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 357:     if (fn != NULL && fn->isMaterializable()) {
It would be good to add a comment along the lines of "The global variable that referenced
'fn' may not have been linked into 'module_', e.g. if it was private"


http://gerrit.cloudera.org:8080/#/c/5384/3/be/src/testutil/test-udfs.cc
File be/src/testutil/test-udfs.cc:

Line 23: #define NO_INLINE __attribute__((noinline))
Can you do a quick double-check before committing that this compiles with ASAN and release
builds. Just in case there's something funky there.


Line 164: typedef DoubleVal (*TestFn)(const DoubleVal& base, const DoubleVal& exp);
Nice!


PS3, Line 183: interal
internal


PS3, Line 184: overriden
overridden


PS3, Line 198: overriden
overridden here and below


http://gerrit.cloudera.org:8080/#/c/5384/3/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:

We're going to have some merge conflicts in this test file, let's make sure to coordinate
who merges first.


-- 
To view, visit http://gerrit.cloudera.org:8080/5384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa056a0c888bfcc95b412e1bc1063bb607b58ab7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message