impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
Date Wed, 07 Dec 2016 16:07:10 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
......................................................................


Patch Set 1:

(4 comments)

Thank you for the reviews. Please see PS2.

http://gerrit.cloudera.org:8080/#/c/5390/1/common/thrift/Frontend.thrift
File common/thrift/Frontend.thrift:

Line 182:   1: required bool is_show_col_stats
> replace the two flags by an enum and use the thrift enum in the stmt code?
Done


http://gerrit.cloudera.org:8080/#/c/5390/1/fe/src/main/java/org/apache/impala/analysis/ShowPartitionsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ShowPartitionsStmt.java:

Line 64:       if (kuduTable.getPrimaryKeyColumnNames().isEmpty()) {
> Not possible. Kudu tables must have PKs.
Done


http://gerrit.cloudera.org:8080/#/c/5390/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java:

Line 31:   protected final boolean isShowColStats_;
> The subclasses and flags are getting kind of confusing.
I gave this a try with enums and like how it turned out. It also allows for easier extension
in the future.


http://gerrit.cloudera.org:8080/#/c/5390/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:

Line 432:       for (String partition: partitions) {
> Do you know if the partitions are sorted? Might be good to do that, otherwi
Yes, the comment in the kudu client API explains that they are sorted. I added a comment here.


-- 
To view, visit http://gerrit.cloudera.org:8080/5390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5b2fdd02938a42fa59ec98884e4ac915dd1f65
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message