impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4595: Ignore discarded functions after linking
Date Wed, 07 Dec 2016 02:33:16 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4595: Ignore discarded functions after linking
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5384/1/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

PS1, Line 357: fn != NULL
> On a second thought, that shouldn't be possible. Otherwise, ref_fns would h
It seems like it's possible that a global variable in 'new_module' references functions, but
the global variable definition is not brought across in the linking (e.g. it is private or
a preexisting definition takes precedence).


-- 
To view, visit http://gerrit.cloudera.org:8080/5384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa056a0c888bfcc95b412e1bc1063bb607b58ab7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message