impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently
Date Wed, 07 Dec 2016 01:29:54 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5377/2//COMMIT_MSG
Commit Message:

PS2, Line 10:  the slots contain escape characters. 
> May help to clarify that the problem shows up when the tuple only contains 
Done


http://gerrit.cloudera.org:8080/#/c/5377/2/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

PS2, Line 460: // Convert length to positive if it is negative.
> I wonder if this should be emitted for text scanner only. I believe we only
The non-codegen'd equivalent doesn't make that distinction, so it should be safe to do this
here.
https://github.com/apache/incubator-impala/blob/master/be/src/exec/hdfs-scanner.cc#L235-L238


PS2, Line 468: positive_len = buil
> abs_len  or positive_len ?
Done


PS2, Line 469: ones_compliment_len, codegen->GetIntConstant(TYPE_INT, 1),
> nit: long line
Done


http://gerrit.cloudera.org:8080/#/c/5377/2/be/src/exec/text-converter.cc
File be/src/exec/text-converter.cc:

PS2, Line 171:     Value* null_len = builder.CreateICmpEQ(
             :         args[2], codegen->GetIntConst
> Remove.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I858e427ad7c2b2da8c2bb657be06b7443655781f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message