impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
Date Wed, 07 Dec 2016 01:08:07 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
......................................................................


Patch Set 1:

Thanks, Lars!

So firstly, this functionality I think is pretty important so worth trying to get in. At first
I was thinking that plumbing this through the 'ShowStats' path was too wonky, and that we'd
probably want to just add separate classes/functions for a parallel path. However after thinking
more about it, I think it's actually not the craziest thing to consider this a kind of ShowStats
command. Right now it doesn't have any stats, but I think in the future we'd probably want
to show number of rows. There's no way to get that info today, but with some help from Kudu
it could be possible. That'd be super useful.

So to summarize, I'd be OK with this approach. We can add some TODOs about adding stats later.
Let's see what others think.

-- 
To view, visit http://gerrit.cloudera.org:8080/5390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5b2fdd02938a42fa59ec98884e4ac915dd1f65
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message