impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4585: Replace HDFS FILENAME actual paths
Date Wed, 07 Dec 2016 00:41:32 GMT
Hello Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5372

to look at the new patch set (#2).

Change subject: IMPALA-4585: Replace __HDFS_FILENAME__ actual paths
......................................................................

IMPALA-4585: Replace __HDFS_FILENAME__ actual paths

In a recent change (IMPALA-4363) we introduced where all paths .test
files should be replaced with __HDFS_FILENAME__. This caused problems
for tests on non-HDFS file systems. We also lost some test coverage.
This patch fixes the problem by allowing the $NAMENODE template in the
catch section of the .test file.

Change-Id: If0f6ae8dea7ac4cdaf0c61ebd8f0c589c353a96e
---
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-abort-on-error.test
M testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M tests/common/impala_test_suite.py
6 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/5372/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If0f6ae8dea7ac4cdaf0c61ebd8f0c589c353a96e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>

Mime
View raw message