impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.
Date Tue, 06 Dec 2016 23:49:15 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5386/3/fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java
File fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java:

PS3, Line 129: This error is thrown to prevent " +
             :           "returning wrong results because Impala cannot assign/evaluate "
+
             :           "this non-deterministic predicate correctly.
That statement doesn't seen to be always true, right? We do allow in some cases non-deterministic
predicates (e.g. rand() < non_partition_col). So maybe we should remove this part and indicate
why we reject this here (e.g. applied during partition pruning or something along these lines).


-- 
To view, visit http://gerrit.cloudera.org:8080/5386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94765f62bde94f4faa7fc5c26d928099ca1496d1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message