impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add Apache license header to files in doc directory
Date Tue, 06 Dec 2016 22:31:12 GMT
John Russell has posted comments on this change.

Change subject: Add Apache license header to files in doc directory
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Add Apache license header to files in doc directory
> No, I used "replace".
To sanity-check the logic, what was the exact 'replace' command? I.e. was it to replace line
1:

<?xml version="1.0" encoding="UTF-8"?>

with line 1 + version notice? Is/was there an option to say "only replace the first instance"?

If there's an unusual file with a different <?xml?> header line, or a second instance
inside a comment, I would doublecheck that with grep -l or grep -c for an extra level of confidence.
That's why it helps me to know the precise search/replace procedure.


-- 
To view, visit http://gerrit.cloudera.org:8080/5232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message