impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes
Date Tue, 06 Dec 2016 20:17:57 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3788: Add flag for Kudu read-your-writes
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5288/2/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 143:   }
mode = FLAGS_kudu_read_latest ? READ_LATEST : READ_AT_SNAPSHOT
SetReadMode(mode, "blah");

would be a bit more readable, but okay to ignore if you disagree.


-- 
To view, visit http://gerrit.cloudera.org:8080/5288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I003aba410548bc9158d1e11abbdcf710c31a82ff
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dralves@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message