impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
Date Tue, 06 Dec 2016 19:06:46 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5382/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

PS1, Line 287: DISTRIBUTE BY
This is no longer true. The clause is "PARTITION BY".


http://gerrit.cloudera.org:8080/#/c/5382/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

PS1, Line 1964: into 2
Is this valid syntax?


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

PS1, Line 799: DISTRIBUTE
Hm, that should be PARTITION.


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/tests/test_cursor.py
File tests/comparison/tests/test_cursor.py:

PS1, Line 79: DISTRIBUTE
PARTITION


PS1, Line 83: DISTRIBUTE
PARTITION


-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburkert@apache.org>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburkert@apache.org>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message