impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous
Date Mon, 05 Dec 2016 22:21:08 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5364/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:

Line 432:    * the alter table operation is finished or until the operation timeout is reached.
> is there a way for us to distinguish failure from timeout?
If the function returns false it means it timed out.


Line 435:   public static void alterKuduTable(KuduTable tbl, AlterTableOptions ato, String
errMsg)
> pass name and master hosts list? then you can use this for the renameTable(
Hm, not sure how this would work. For the rename you need to call the operation on the old
name but check (call isAlterTableDone) on the new name.


-- 
To view, visit http://gerrit.cloudera.org:8080/5364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I385bce66691ae9040e72f97557e1bba31009e36b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message