impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.
Date Mon, 05 Dec 2016 09:16:11 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4960/3//COMMIT_MSG
Commit Message:

Line 32: Change-Id: I774d13a13ad1e8fe82512df98dc29983bdd232eb
what does 'equivalent outer-joined tuples' mean? (equivalent to what?)


http://gerrit.cloudera.org:8080/#/c/4960/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

Line 1542:           // after the join (IMPALA-2018/4379). The first condition is conservative
but
what does 'after *the* join' mean? in your example test case, the predicate doesn't come from
a join.


http://gerrit.cloudera.org:8080/#/c/4960/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:

Line 1194:     Expr.removeDuplicates(conjuncts);
> Explained duplicates in commit msg with an example.
i agree in principle, but isn't that a trivial change?


-- 
To view, visit http://gerrit.cloudera.org:8080/4960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774d13a13ad1e8fe82512df98dc29983bdd232eb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #27
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message