impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration
Date Mon, 05 Dec 2016 05:25:16 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5255/2/fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
File fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java:

Line 168:    * Attempts to parse decimal type information from the Avro schema, returning
> This comment is now out-of-sync with the method.
Done


Line 178:     if (logicalType.equalsIgnoreCase("decimal")) {
> I think this should be checked before calling getDecimalType(). It makes mo
Done


Line 193:           "Unsupported logicalType");
> Should include the type name in the exception method so that users can unde
Previous comment -
  3. getDecimalType() should now either return a valid type or throw an exception.

Done.
Had to move the exception in an else statement 
since 
if (logicalType.equalsIgnoreCase("decimal")) 
this check was moved outside.


-- 
To view, visit http://gerrit.cloudera.org:8080/5255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad23706128223b6537d565471ef5d8faa91b0b5a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message