impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4303: Do not reset() qualifier of union operands.
Date Sun, 04 Dec 2016 05:30:55 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4303: Do not reset() qualifier of union operands.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4963/2/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java
File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java:

Line 371:     for (UnionOperand op: distinctOperands_) {
> single line
Done


Line 374:     for (UnionOperand op: allOperands_) {
> same
Done


Line 611:    * Undoes all changes made by analyze() except distinct propagation and unnesting.
> i'm fine with leaving this here, but i think this reflects the ambiguous se
Yep, I see your point. This is actually not the only place where reset() provides weaker semantics
than requested in StatementBase. You are right about wanting to rethink the semantics to be
more accurate/appropriate.


-- 
To view, visit http://gerrit.cloudera.org:8080/4963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157bb0f08c4a94fd779487d7c23edd64a537a1f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message