impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4577: Adjust maximum size of row batch queue with MT DOP.
Date Sat, 03 Dec 2016 06:46:01 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4577: Adjust maximum size of row batch queue with MT_DOP.
......................................................................


IMPALA-4577: Adjust maximum size of row batch queue with MT_DOP.

When MT_DOP is set, non-Parquet scans are run with the old
scan node with a fixed NUM_SCANNER_THREADS=1. This patch
adjust the maximum size of the row batch queue based on MT_DOP
for each such scan instance to avoid a significant increase in
the memory consumption of such scans. The max queued batches
per scan-node instance is at least 2 to always allow for some
parallelism between the producer/consumer.

Decreases the maximum allowed value for MT_DOP from 128 to 64.

Change-Id: Ic2aa260f9265ec21173fb703c41934964ece6485
Reviewed-on: http://gerrit.cloudera.org:8080/5330
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-scan-node.h
M be/src/service/query-options.cc
3 files changed, 24 insertions(+), 11 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2aa260f9265ec21173fb703c41934964ece6485
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message