impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4572: Run COMPUTE STATS on Parquet tables with MT DOP&2E
Date Sat, 03 Dec 2016 02:14:42 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4572: Run COMPUTE STATS on Parquet tables with MT_DOP=4.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5315/1/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 193:   // unset or 0: single-threaded execution mode
> This isn't totally right. unset means 0 after we get past createExecRequest
Good point. Done.


http://gerrit.cloudera.org:8080/#/c/5315/1/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:

Line 231:     Preconditions.checkState(ctx_.getQueryOptions().mt_dop > 0);
> This needs to be check if it's set too right?
Not anymore.


http://gerrit.cloudera.org:8080/#/c/5315/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

Line 1052:       if (!queryCtx.request.query_options.isSetMt_dop() &&
> It would simplify the rest of the code if we always set mt_dop to the effec
Good idea. Done.


Line 1052:       if (!queryCtx.request.query_options.isSetMt_dop() &&
> i think even if you leave 0 as a default in the .thrift file you can still 
I tried it out and having a default value means isSet() returns true.


-- 
To view, visit http://gerrit.cloudera.org:8080/5315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2be3c7c9f3004e9a759224a2e5756eb6e4efa359
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message