impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation
Date Sat, 03 Dec 2016 01:40:50 GMT
Hello Alex Behm,

I'd like you to reexamine a change.  Please visit

to look at the new patch set (#10).

Change subject: IMPALA-4363: Add Parquet timestamp validation

IMPALA-4363: Add Parquet timestamp validation

Before this patch, we would simply read the INT96 Parquet timestamp
representation and assume that it's valid. However, not all bit
permutations represent a valid timestamp. One of the boost functions
raised an exception (that we didn't catch) when passed an invalid
boost date object, which resulted in a crash. This patch fixes
problem by validating that the date falls into 1400..9999 year
range and time falls into 00:00:00..23:59:59.999999999 range as we
are scanning Parquet.

Change-Id: I9988449aa0dc0f39fabb91ce6cce0dd8a06e8bcf
M be/src/exec/
M be/src/exec/parquet-column-readers.h
M be/src/runtime/timestamp-value.h
M common/thrift/
M testdata/data/README
A testdata/data/out_of_range_timestamp.parquet
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
A testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-abort-on-error.test
A testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M tests/common/
M tests/query_test/
13 files changed, 142 insertions(+), 36 deletions(-)

  git pull ssh:// refs/changes/68/4968/10
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9988449aa0dc0f39fabb91ce6cce0dd8a06e8bcf
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message