impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4577: Adjust maximum size of row batch queue with MT DOP.
Date Sat, 03 Dec 2016 01:39:03 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4577: Adjust maximum size of row batch queue with MT_DOP.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5330/2/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

Line 149:   if (state->query_options().__isset.mt_dop && state->query_options().mt_dop
> 0) {
> if you leave the mt_dop default at 0, then "> 0" is sufficient.
I did a simple experiment with and without a default value.
With a default value, isSet() returns true.
Without a default value it returns false.


Line 158:   if (VLOG_QUERY_IS_ON) {
> this if is superfluous from a perf perspective.
Understood. I did it because the pattern is applied everywhere else in this file. Removed.


-- 
To view, visit http://gerrit.cloudera.org:8080/5330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2aa260f9265ec21173fb703c41934964ece6485
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message