impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts
Date Sat, 03 Dec 2016 00:39:07 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts
......................................................................


Patch Set 1:

(3 comments)

> I saw Todd has a change to address this on the client side.. is
 > this just a bandaid until that change comes in, or do we plan to
 > keep this change?

I'm not sure yet, I was going to try porting his patch over after we branch for the release.
His patch is cool, but it's more moving pieces and it's generally not as useful for Impala
since we don't use WARNING frequently, and thus maybe not worth the added complexity. Really
it should just be fixed in upstream glog, Todd filed a ticket upstream.

TL;DR, wait and see.

http://gerrit.cloudera.org:8080/#/c/5334/1//COMMIT_MSG
Commit Message:

PS1, Line 13: An easy solution for now is to downgrade Kudu WARNINGs to INFOs as
            : WARNINGs grab a lock to flush the log.
and mention that Kudu warns much more frequently than Impala does, for things that we'd consider
to be INFO-level typically.


http://gerrit.cloudera.org:8080/#/c/5334/1/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

PS1, Line 81: we
remove


PS1, Line 88: We l
remove We


-- 
To view, visit http://gerrit.cloudera.org:8080/5334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie535d89ec2525232d4f6a29dd44f51cd6e18a0d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message