impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4580: Fix crash with FETCH FIRST when #rows < result cache size
Date Sat, 03 Dec 2016 00:30:47 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4580: Fix crash with FETCH_FIRST when #rows < result cache size
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5335/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 1108:     // May be called after the first time we set *eos. Re-set *eos and return quickly.
This comment seemed misleading to me becuase it makes it sound like it's here just as an optimization.
 How about either deleting this comment or rewording about the teardown?


-- 
To view, visit http://gerrit.cloudera.org:8080/5335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I454cd8a6cf438bdd0c49fd27c2725d8f6c43bb1d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message