impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4303: Do not reset() qualifier of union operands.
Date Fri, 02 Dec 2016 23:01:40 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4303: Do not reset() qualifier of union operands.
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4963/2/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java
File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java:

Line 371:     for (UnionOperand op: distinctOperands_) {
single line


Line 374:     for (UnionOperand op: allOperands_) {
same


Line 611:    * Undoes all changes made by analyze() except distinct propagation and unnesting.
i'm fine with leaving this here, but i think this reflects the ambiguous semantics of reset()
(what's done here is clearly less than what's asked for in StatementBase; the question then
is: what are the actual semantics that are needed?). just something to keep in mind.


-- 
To view, visit http://gerrit.cloudera.org:8080/4963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157bb0f08c4a94fd779487d7c23edd64a537a1f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message